Github user maropu commented on the issue:

    https://github.com/apache/spark/pull/19473
  
    LGTM. btw, do we have any chance to add the same metrics in 
`SortAggregateExec` and `ObjectHashAggregateExec`? It seems we cannot simply 
add the metrics in both cuz they use the iterator to aggregate inputs. But, I 
think it might help for users.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to