Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144184155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,9 +81,13 @@ class ExpressionSet protected(
}
override def -(elem: Expression): ExpressionSet = {
- val newBaseSet = baseSet.clone().filterNot(_ == elem.canonicalized)
- val newOriginals = originals.clone().filterNot(_.canonicalized ==
elem.canonicalized)
- new ExpressionSet(newBaseSet, newOriginals)
+ if (elem.deterministic) {
+ val newBaseSet = baseSet.clone().filterNot(_ == elem.canonicalized)
+ val newOriginals = originals.clone().filterNot(_.canonicalized ==
elem.canonicalized)
+ new ExpressionSet(newBaseSet, newOriginals)
+ } else {
+ new ExpressionSet(baseSet.clone(), originals.clone())
--- End diff --
Sorry, for `Set` I mean the whole `ExpressionSet`.
Please check the logic in `CombineFilters` and my new test case, you will
understand me immediately.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
