Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19424#discussion_r144209319
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceReaderHolder.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import java.util.Objects
+
+import org.apache.spark.sql.catalyst.expressions.{Attribute,
AttributeReference}
+import org.apache.spark.sql.sources.v2.reader._
+
+/**
+ * A base class for data source reader holder and defines equals/hashCode
methods.
+ */
+trait DataSourceReaderHolder {
+ def fullOutput: Seq[AttributeReference]
+ def reader: DataSourceV2Reader
+
+ override def equals(other: Any): Boolean = other match {
+ case other: DataSourceV2Relation =>
+ val basicEquals = this.fullOutput == other.fullOutput &&
+ this.reader.getClass == other.reader.getClass &&
+ this.reader.readSchema() == other.reader.readSchema()
+
+ val samePushedFilters = (this.reader, other.reader) match {
+ case (l: SupportsPushDownCatalystFilters, r:
SupportsPushDownCatalystFilters) =>
+ l.pushedCatalystFilters().toSeq ==
r.pushedCatalystFilters().toSeq
+ case (l: SupportsPushDownFilters, r: SupportsPushDownFilters) =>
+ l.pushedFilters().toSeq == r.pushedFilters().toSeq
--- End diff --
good catch!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
