Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/19448#discussion_r144375059
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -138,6 +138,11 @@ class ParquetFileFormat
conf.setBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
}
+ require(!conf.getBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
+ || classOf[ParquetOutputCommitter].isAssignableFrom(committerClass),
+ s"Committer $committerClass is not a ParquetOutputCommitter and
cannot create job summaries."
+ + " Set Parquet option " + ParquetOutputFormat.ENABLE_JOB_SUMMARY + "
to false.")
--- End diff --
I'd thought about that; didn't look any better or worse. Will change it for
log message.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
