Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19480#discussion_r144480289
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
 ---
    @@ -201,6 +201,23 @@ class CodeGenerationSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         }
       }
     
    +  test("SPARK-22226: group splitted expressions into one method per nested 
class") {
    --- End diff --
    
    thank you very much for your help @viirya ! In my use cases it seemed to be 
connected to the `dropDuplicates` method and I focused on it, but thanks to 
your suggestion now I realize that `dropDuplicates` by itself is not enough, it 
needs also some functions applied to columns to generate the issue! Thank you 
so much. Where should I add this test case?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to