Github user superbobry commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19458#discussion_r144655974
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
    @@ -100,7 +100,16 @@ private[spark] class DiskBlockManager(conf: SparkConf, 
deleteFilesOnStop: Boolea
     
       /** List all the blocks currently stored on disk by the disk manager. */
       def getAllBlocks(): Seq[BlockId] = {
    -    getAllFiles().map(f => BlockId(f.getName))
    +    getAllFiles().flatMap { f =>
    +      val blockId = BlockId.guess(f.getName)
    --- End diff --
    
    Will do. Should I log the exception even if the file has been produced by 
`Utils.tempFileWith`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to