Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19363#discussion_r144873610
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1341,8 +1341,69 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
Seq(1).toDS().map(_ => ("", TestForTypeAlias.seqOfTupleTypeAlias)),
("", Seq((1, 1), (2, 2))))
}
+
+ test("Check RelationalGroupedDataset toString: Single data") {
+ val kvDataset = (1 to 3).toDF("id").groupBy("id")
+ val expected = "RelationalGroupedDataset: [" +
+ "group by: [id: int], value: [id: int], type: GroupByType]"
--- End diff --
a better idea:
* `group by` -> `grouping expressions`
* `type: GroupByType` -> `type: GroupBy`, i.e. remove the `Type` suffix.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
