Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r145237956
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -380,7 +389,8 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
} else {
declineOffer(
driver,
- offer)
+ offer,
--- End diff --
At this point we decline any offer we couldnt use to launch a task... In
order to have a reason like why the checkcanLaunchTask previously failed for
that offer we have to store the related info somewhere. Alternatively I propose
to log that failure at the canLaunchTask call earlier and call decline here as
follows:
```
declineOffer(
driver,
Some("Offer was declined due to unmet task launch constraints.")
offer)
```
Sounds good?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
