Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19522#discussion_r145278393
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ---
    @@ -102,8 +102,8 @@ case class InMemoryTableScanExec(
         case IsNull(a: Attribute) => statsFor(a).nullCount > 0
         case IsNotNull(a: Attribute) => statsFor(a).count - 
statsFor(a).nullCount > 0
     
    -    case In(_: AttributeReference, list: Seq[Expression]) if list.isEmpty 
=> Literal.FalseLiteral
    -    case In(a: AttributeReference, list: Seq[Expression]) if 
list.forall(_.isInstanceOf[Literal]) =>
    +    case In(a: AttributeReference, list: Seq[Expression])
    +      if list.forall(_.isInstanceOf[Literal]) && list.nonEmpty =>
    --- End diff --
    
    I will, as soon as we decide which is the right behavior, thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to