Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17862#discussion_r146166006
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
    @@ -282,8 +348,27 @@ class LinearSVC @Since("2.2.0") (
     @Since("2.2.0")
     object LinearSVC extends DefaultParamsReadable[LinearSVC] {
     
    +  /** String name for Limited-memory BFGS. */
    +  private[classification] val LBFGS: String = 
"l-bfgs".toLowerCase(Locale.ROOT)
    +
    +  /** String name for Orthant-Wise Limited-memory Quasi-Newton. */
    +  private[classification] val OWLQN: String = 
"owlqn".toLowerCase(Locale.ROOT)
    +
    +  /* Set of optimizers that LinearSVC supports */
    +  private[classification] val supportedSolvers = Array(LBFGS, OWLQN)
    +
    +  /** String name for Hinge Loss. */
    +  private[classification] val HINGE: String = 
"hinge".toLowerCase(Locale.ROOT)
    +
    +  /** String name for Squared Hinge Loss. */
    +  private[classification] val SQUARED_HINGE: String = 
"squared_hinge".toLowerCase(Locale.ROOT)
    +
    +  /* Set of loss function that LinearSVC supports */
    +  private[classification] val supportedLoss = Array(HINGE, SQUARED_HINGE)
    --- End diff --
    
    Sure. I can update it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to