Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19561#discussion_r146342937
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -89,7 +89,11 @@ trait FutureAction[T] extends Future[T] {
*/
override def value: Option[Try[T]]
- // These two methods must be implemented in Scala 2.12, but won't be
used by Spark
+ // These two methods must be implemented in Scala 2.12. They're
implemented as a no-op here
+ // and then filled in with a real implementation in the two subclasses
below. The no-op exists
+ // here so that those implementations can declare "override", necessary
in 2.12, while working
+ // in 2.11, where the method doesn't exist in the superclass.
+ // After 2.11 support goes away, remove these two:
--- End diff --
In case it wasn't clear, this change ought to have no effect at all in 2.11
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
