Github user falaki commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19551#discussion_r146345486
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -499,6 +499,12 @@ test_that("create DataFrame with different data 
types", {
       expect_equal(collect(df), data.frame(l, stringsAsFactors = FALSE))
     })
     
    +test_that("SPARK-17902: collect() with stringsAsFactors enabled", {
    --- End diff --
    
    BTW: I think iris data frame all Species values are clustered together. 
That is why the test is passing (the new factor order ends up being identical 
to the existing order).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to