Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/19536#discussion_r146511769 --- Diff: project/MimaExcludes.scala --- @@ -1043,6 +1043,9 @@ object MimaExcludes { // [SPARK-21680][ML][MLLIB]optimzie Vector coompress ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.mllib.linalg.Vector.toSparseWithSize"), ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.linalg.Vector.toSparseWithSize") + ) ++ Seq( + // [SPARK-6685][ML]Use DSYRK to compute AtA in ALS + ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.recommendation.ALS.train") --- End diff -- I am ok to remove this, and use a loose threshold (e.g. 100), which is helpful for most cases. How about it?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org