GitHub user rdblue opened a pull request:
https://github.com/apache/spark/pull/19568
SPARK-22345: Fix sort-merge joins with conditions and codegen.
## What changes were proposed in this pull request?
This adds a joined row to sort-merge join codegen. That joined row is used
to generate code for filter expressions, which may fall back to using the
result row. Previously, the right side of the join was used, which is incorrect
(the non-codegen implementations use a joined row).
## How was this patch tested?
Current tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdblue/spark
SPARK-22345-fix-sort-merge-codegen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19568
----
commit 4afb088a4fa2127cab7467cc56f58cd77bd8c251
Author: Ryan Blue <b...@apache.org>
Date: 2017-10-24T20:21:50Z
SPARK-22345: Fix sort-merge joins with conditions and codegen.
Code for the condition was generated to depend on the right row instead
of the joined row.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
