Github user akopich commented on the issue:

    https://github.com/apache/spark/pull/19565
  
    Now I feel that filtering empty docs out in the `initialize` is not a good 
idea, because it will be performed as many times, as the number of times 
`sample` in `next` gets called. Right?
    
    Alternatively we can cache `this.docs`, but it's a waste of space...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to