Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19437#discussion_r146702275
  
    --- Diff: docs/running-on-mesos.md ---
    @@ -501,23 +503,78 @@ See the [configuration page](configuration.html) for 
information on Spark config
         spark.mesos.driver.secret.names or spark.mesos.driver.secret.values 
will be
         written to the provided file. Paths are relative to the container's 
work
         directory.  Absolute paths must already exist.  Consult the Mesos 
Secret
    -    protobuf for more information.
    +    protobuf for more information. Note: File-based secrets require a 
custom
    +    <a 
href="http://mesos.apache.org/documentation/latest/secrets/";>SecretResolver
    +    module</a>. Example:
    +    
    +    <pre>filename1,filename2</pre>
       </td>
     </tr>
     <tr>
       <td><code>spark.mesos.driver.secret.names</code></td>
       <td><code>(none)</code></td>
       <td>
         A comma-separated list of secret references. Consult the Mesos Secret
    -    protobuf for more information.
    +    protobuf for more information. Example:
    +    
    +    <pre>secretname1,secretname2</pre>
       </td>
     </tr>
     <tr>
       <td><code>spark.mesos.driver.secret.values</code></td>
       <td><code>(none)</code></td>
       <td>
         A comma-separated list of secret values. Consult the Mesos Secret
    -    protobuf for more information.
    +    protobuf for more information. Example:
    +    
    +    <pre>secretvalue1,secretvalue2</pre>
    +  </td>
    +</tr>
    +
    +<tr>
    +  <td><code>spark.mesos.executor.secret.envkeys</code></td>
    +  <td><code>(none)</code></td>
    +  <td>
    +    A comma-separated list that, if set, the contents of the secret 
referenced
    --- End diff --
    
    Let me try to improve the descriptions of all these secret configs.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to