Github user Whoosh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19553#discussion_r147007902
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -43,6 +43,13 @@ private[spark] object JavaUtils {
override def size: Int = underlying.size
+ // Delegate to implementation because AbstractMap implementation
iterates over whole key set
+ override def containsKey(key: AnyRef): Boolean = try {
--- End diff --
@srowen
Yeah, you're right -) I have been focused on code around. Scala isn't my
language haven't known that construction, thx.
> What about other methods -- anything worth plumbing directly to the
underlying implementation?
Yep, checked, remove(key) still plumbing, actually, I don't know how to
simply fix it, cuz there are no methods to remove it without recreating a new
Map.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
