Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19559#discussion_r147035765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -139,6 +139,7 @@ class Analyzer(
ExtractGenerator ::
ResolveGenerate ::
ResolveFunctions ::
+ ResolveLiteralFunctions ::
--- End diff --
The order matters. It assumes `ResolveReferences` should be run before this
rule. However, `ResolveReferences` might need multiple passes to resolve all
the references. Thus, how about moving the logics into `ResolveReferences `? If
the attributes are not resolvable, we try to see whether it is a function
literal?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
