Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19580#discussion_r147288373
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -787,7 +791,9 @@ private[spark] class ExecutorAllocationManager(
         /**
          * The number of tasks currently running across all stages.
          */
    -    def totalRunningTasks(): Int = numRunningTasks
    +    def totalRunningTasks(): Int = {
    +      stageIdToNumRunningTask.values.sum
    --- End diff --
    
    This needs to be inside `allocationManager.synchronized`, no?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to