Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19567#discussion_r147317145
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
 ---
    @@ -456,8 +456,17 @@ object JdbcUtils extends Logging {
     
             case StringType =>
               (array: Object) =>
    -            array.asInstanceOf[Array[java.lang.String]]
    -              .map(UTF8String.fromString)
    +            array match {
    +              case _: Array[java.lang.String] =>
    +                array.asInstanceOf[Array[java.lang.String]]
    +                  .map(UTF8String.fromString)
    +              case _: Array[java.util.UUID] =>
    +                array.asInstanceOf[Array[java.util.UUID]]
    --- End diff --
    
    Having a separate case for UUID is more clear to me and maybe easy to debug 
in the future. However I'm not sure how long this matching cases can be grown.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to