GitHub user xynny opened a pull request:

    https://github.com/apache/spark/pull/19597

    [SPARK-22375][TEST] Test script can fail if eggs are installed by set…

    …up.py during test process
    
    ## What changes were proposed in this pull request?
    
    Ignore the python/.eggs folder when running lint-python
    
    ## How was this patch tested?
    1) put a bad python file in python/.eggs and ran the original script.  
results were:
    
    xins-MBP:spark xinlu$ dev/lint-python 
    PEP8 checks failed.
    ./python/.eggs/worker.py:33:4: E121 continuation line under-indented for 
hanging indent
    ./python/.eggs/worker.py:34:5: E131 continuation line unaligned for hanging 
indent
    
    
    2) test same situation with change:
    
    xins-MBP:spark xinlu$ dev/lint-python 
    PEP8 checks passed.
    The sphinx-build command was not found. Skipping pydoc checks for now
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xynny/spark SPARK-22375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19597
    
----
commit 956890612db181f5f470593f10fe02048cecaf03
Author: Xin Lu <x...@salesforce.com>
Date:   2017-10-28T16:23:33Z

    [SPARK-22375][TEST] Test script can fail if eggs are installed by setup.py 
during test process

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to