Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r147565833 --- Diff: common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java --- @@ -38,6 +39,10 @@ public static int hashLong(long input) { return (int) ((input >>> 32) ^ input); } + public static int hashUnsafeBytesBlock(MemoryBlock base, long offset, int lengthInBytes) { --- End diff -- why we call it `hashUnsafeBytesBlock` while passing in a general `MemoryBlock`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org