Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19601#discussion_r147578600
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -367,9 +551,13 @@ public Object get(int ordinal, DataType dataType) {
/**
* Returns the array at rowid.
*/
- public final ColumnVector.Array getArray(int rowId) {
- resultArray.length = getArrayLength(rowId);
- resultArray.offset = getArrayOffset(rowId);
+ public final ArrayData getArray(int rowId) {
--- End diff --
I see.
One question. `ColumnVector.Array` has some public fields such as `length`.
I think that it would be good to use an accessor `length` or `getLength`. What
do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
