Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19624#discussion_r148320092
  
    --- Diff: R/pkg/R/sparkR.R ---
    @@ -420,6 +420,18 @@ sparkR.session <- function(
                                     enableHiveSupport)
         assign(".sparkRsession", sparkSession, envir = .sparkREnv)
       }
    +
    +  # Check if version number of SparkSession matches version number of 
SparkR package
    +  jvmVersion <- callJMethod(sparkSession, "version")
    +  # Remove -SNAPSHOT from jvm versions
    +  jvmVersion <- gsub("-SNAPSHOT", "", jvmVersion)
    +  rPackageVersion <- paste0(packageVersion("SparkR"))
    +
    +  if (jvmVersion != rPackageVersion) {
    +    warning(paste("Version mismatch between Spark JVM and SparkR package. 
JVM version was",
    +                  jvmVersion, ", while R package version was", 
rPackageVersion))
    --- End diff --
    
    I wonder if that would be more confusing as somebody might think they just 
need to remove the `-snapshot` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to