Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/19623#discussion_r148325887
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriter.java
---
@@ -84,9 +86,9 @@
* This method will only be called if there is one record failed to
write, or {@link #commit()}
* failed.
*
- * If this method fails(throw exception), the underlying data source may
have garbage that need
- * to be cleaned by {@link
DataSourceV2Writer#abort(WriterCommitMessage[])} or manually, but
- * these garbage should not be visible to data source readers.
+ * If an exception was thrown, the underlying data source may have
garbage that need to be
+ * cleaned by {@link DataSourceV2Writer#abort(WriterCommitMessage[])} or
manually, but these
+ * garbage should not be visible to data source readers.
*/
void abort();
--- End diff --
May as well declare throws IOE here too, because things invoked are likely
to declare that, and whatever calls this is going to need to be catching and
downgrading all exceptions anyway
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
