Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19565#discussion_r148437931 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -446,14 +445,14 @@ final class OnlineLDAOptimizer extends LDAOptimizer with Logging { override private[clustering] def next(): OnlineLDAOptimizer = { val batch = docs.sample(withReplacement = sampleWithReplacement, miniBatchFraction, randomGenerator.nextLong()) - if (batch.isEmpty()) return this --- End diff -- I think isEmpty() is optimized to avoid a full materialization.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org