Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r148860542
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -108,6 +108,13 @@ abstract class MLWriter extends BaseReadWrite with
Logging {
protected def saveImpl(path: String): Unit
/**
+ * `option()` handles extra options. If subclasses need to support extra
options, override this
+ * method.
+ */
+ @Since("2.3.0")
+ def option(key: String, value: String): this.type = this
--- End diff --
Rather than overriding this in each subclass, let's have this option()
method collect the specified options in a map which is consumed by the subclass
when saveImpl() is called.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
