Github user mpetruska commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19659#discussion_r148930766
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/NGram.scala ---
    @@ -57,10 +68,22 @@ class NGram @Since("1.5.0") (@Since("1.5.0") override 
val uid: String)
       @Since("1.5.0")
       def getN: Int = $(n)
     
    +  /** @group setParam */
    +  @Since("From which version?")
    +  def setMaxN(value: Int): this.type = set(maxN, value)
    +
    +  /** @group getParam */
    +  @Since("From which version?")
    --- End diff --
    
    Note to self: please fill this in.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to