Github user squito commented on the issue:
https://github.com/apache/spark/pull/19678
Also going to copy this comment from here for others:
https://github.com/vanzin/spark/pull/45
>> squito 12 days ago
>> what do you think about adding a helper method for these json snippets?
obviously not the fault of your change, but I find these so hard to read, eg.
figuring out where data-title ends (worse in some of the other cases esp in
StagePage). something like
```
UIUtils.timelineJsonEvent(
className="executor added",
group="executors",
start = e.addTime.getTime(),
end = None,
contentClass = "executor-event-content",
dataTitle = s"Executor ${e.id}<br> Added at ${UIUtils.formatDate(new
Date(e.addTime.getTime()))}",
contentBody = s"Executor ${e.id} added")
```
> vanzin 11 days ago Owner
> I'm not against it but I'd rather do that separately.
agree, fine to do that later.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
