GitHub user nkronenfeld opened a pull request:
https://github.com/apache/spark/pull/19705
[SPARK-22308][test-maven] Support alternative unit testing styles in
external applications
Continuation of PR#19528
(https://github.com/apache/spark/pull/19529#issuecomment-340252119)
The problem with the maven build in the previous PR was the new tests....
the creation of a spark session outside the tests meant there was more than one
spark session around at a time.
I was using the spark session outside the tests so that the tests could
share data; I've changed it so that each test creates the data anew.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nkronenfeld/spark alternative-style-tests-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19705
----
commit b9d41cd79f05f6c420d070ad07cdfa8f853fd461
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-15T03:04:16Z
Separate out the portion of SharedSQLContext that requires a FunSuite from
the part that works with just any old test suite.
commit 0d4bd97247a2d083c7de55663703b38a34298c9c
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-15T15:57:09Z
Fix typo in trait name
commit 83c44f1c24619e906af48180d0aace38587aa88d
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-15T15:57:42Z
Add simple tests for each non-FunSuite test style
commit e460612ec6f36e62d8d21d88c2344378ecba581a
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-15T16:20:44Z
Document testing possibilities
commit 0ee2aadf29b681b23bed356b14038525574204a5
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-18T23:46:44Z
Better documentation of testing procedures
commit 802a958b640067b99fda0b2c8587dea5b8000495
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-18T23:46:58Z
Same initialization issue in SharedSparkContext as is in SharedSparkSession
commit 4218b86d5a8ff2321232ff38ed3e1b217ff7db2a
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-23T03:49:39Z
Remove documentation of testing
commit 2d927e94f627919ac1546b47072276b23d3e8da2
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-24T04:37:48Z
Move base versions of PlanTest and SQLTestUtils into the same file as where
they came from, in an attempt to make diffs simpler
commit 38a83c081b2f9e28bea6321994fc1a0a0c43f252
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-25T14:42:15Z
Comment line length should be 100
commit 241459a8a4c554877e381fe8306d086ab5b1b152
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-25T14:43:51Z
Move SQLTestUtils object to the end of the file
commit 24fc4a324008b2acfcf5a2617eb7cc320565e83c
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-25T15:00:07Z
fix scalastyle error (whitespace at end of line)
commit e4763d977cffbe7ef362a859c229b74b3cdf4ef3
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-26T02:27:07Z
Remove extraneous curly brackets around empty PlanTest body
commit 6c0b0d569ae1d779fd9253da0c7e97d12634063c
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-10-26T03:24:31Z
Remove extraneous beforeAll and brackets from SharedSQLContext
commit 565c598e89299b8c1473d76249ab732abebdb661
Author: Nathan Kronenfeld <nicole.ore...@gmail.com>
Date: 2017-11-09T06:39:30Z
Make sure no spark sessions are active outside tests
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
