Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19661#discussion_r149927241
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala ---
    @@ -178,6 +179,28 @@ class KryoSerializer(conf: SparkConf)
         
kryo.register(Utils.classForName("scala.collection.immutable.Map$EmptyMap$"))
         kryo.register(classOf[ArrayBuffer[Any]])
     
    +    // We can't load those class directly in order to avoid unnecessary 
jar dependencies.
    +    // We load them safely, ignore it if the class not found.
    +    Seq("org.apache.spark.mllib.linalg.Vector",
    +      "org.apache.spark.mllib.linalg.DenseVector",
    +      "org.apache.spark.mllib.linalg.SparseVector",
    +      "org.apache.spark.mllib.linalg.Matrix",
    +      "org.apache.spark.mllib.linalg.DenseMatrix",
    +      "org.apache.spark.mllib.linalg.SparseMatrix",
    +      "org.apache.spark.ml.linalg.Vector",
    +      "org.apache.spark.ml.linalg.DenseVector",
    +      "org.apache.spark.ml.linalg.SparseVector",
    +      "org.apache.spark.ml.linalg.Matrix",
    +      "org.apache.spark.ml.linalg.DenseMatrix",
    +      "org.apache.spark.ml.linalg.SparseMatrix",
    +      "org.apache.spark.ml.feature.Instance",
    +      "org.apache.spark.ml.feature.OffsetInstance"
    +    ).map(name => Try(Utils.classForName(name))).foreach { t =>
    --- End diff --
    
    a bit curious, can't we do
    ```
    Seq(
      ...
    ).foreach { clsName =>
      try {
        val cls = Utils.classForName(clsName)
        kryo.register(cls)
      } catch {
        case NonFatal(_) => // do nothing
      }
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to