Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18698218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -376,8 +395,8 @@ private[sql] sealed abstract class
ByteArrayColumnType[T <: DataType](
}
}
-private[sql] object BINARY extends ByteArrayColumnType[BinaryType.type](9,
16) {
- override def setField(row: MutableRow, ordinal: Int, value:
Array[Byte]): Unit = {
+private[sql] object BINARY extends
ByteArrayColumnType[BinaryType.type](10, 16) {
+ override def setField(row: MutableRow, ordinal: Int, value: Array[Byte])
{
--- End diff --
Nit: Hmm, actually `: Unit =` is more recommended :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
