Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/19708#discussion_r150287784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
---
@@ -46,4 +46,6 @@ case class SaveIntoDataSourceCommand(
Seq.empty[Row]
}
+
+ override def simpleString: String = s"SaveIntoDataSourceCommand
${dataSource}, ${mode}"
--- End diff --
I can use that, but I would need to expand the default for
`spark.redaction.regex` as the `user` and `url` (some drivers allow credentials
passed in the connection url) fields might also contain sensitive data. We
should also change `JDBCRelation::toString` to include the redaction regex to
be consistent.
I would argue not showing the jdbc properties at all because they provide
little value and wrong redaction regex configuration could cause leaks to
downstream log collection systems.
let me know if that makes sense, and I can modify this accordingly
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
