Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19439 Thanks for the updates! My only remaining comments are about: * Default arguments for readImages in Scala not being Java-friendly (I'd still recommend taking the easy route by having 1 simple method just taking a path + 1 complex method taking all arguments.) * Determinism for sampling (commented above)
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org