Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18113#discussion_r150388500
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala
 ---
    @@ -26,8 +26,9 @@ import org.apache.spark.sql.expressions.Aggregator
     // This file defines internal implementations for aggregators.
     
////////////////////////////////////////////////////////////////////////////////////////////////////
     
    +class TypedSumDouble[IN](val f: IN => Double)
    +  extends Aggregator[IN, Double, Double] {
     
    -class TypedSumDouble[IN](val f: IN => Double) extends Aggregator[IN, 
Double, Double] {
    --- End diff --
    
    let's avoid this unnecessary change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to