Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19720#discussion_r150406191
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
 ---
    @@ -90,7 +86,12 @@ case class Coalesce(children: Seq[Expression]) extends 
Expression {
               }
             }
           """
    -    }.mkString("\n"))
    +    }
    +
    +    ev.copy(code = s"""
    +      ${ev.isNull} = true;
    +      ${ev.value} = ${ctx.defaultValue(dataType)};
    +      ${ctx.splitExpressions(ctx.INPUT_ROW, evals)}""")
    --- End diff --
    
    sorry, I don't see which is the problem here. I see that here the row 
object is `null`, but the goal is to set `ev.isNull` and `ev.value`, which is 
done.  May you explain me if there is something I am missing? Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to