Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19729#discussion_r150420897 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -604,6 +604,8 @@ case class Least(children: Seq[Expression]) extends Expression { val evalChildren = children.map(_.genCode(ctx)) val first = evalChildren(0) --- End diff -- I am thinking about doing what I did in #19720: here we might follow the same approach. Also for consistency across the code. Indeed, there would be an `if` more, but I think that the overhead would be negligible. Or if we state that the right approach is this one to avoid one more `if`, I am best to change my approach in the PR I mentioned.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org