Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15049#discussion_r150495819
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -370,13 +372,11 @@ class ParquetFileFormat
} else {
logDebug(s"Falling back to parquet-mr")
// ParquetRecordReader returns UnsafeRow
- val reader = pushed match {
- case Some(filter) =>
- new ParquetRecordReader[UnsafeRow](
- new ParquetReadSupport,
- FilterCompat.get(filter, null))
- case _ =>
- new ParquetRecordReader[UnsafeRow](new ParquetReadSupport)
+ val reader = if (pushed.isDefined && enableRecordFilter) {
--- End diff --
Oh, I have been looking at the JIRA as well but I thought that only exists
in 1.9.0 as specified in the JIRA, also given
https://github.com/apache/spark/pull/14671#issuecomment-240472754. Looks that
flag also exists in Parquet 1.8.2 as well.
Yup, I don't have strong preference too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
