Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r150621371
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala ---
@@ -298,8 +385,21 @@ object TrainValidationSplitModel extends
MLReadable[TrainValidationSplitModel] {
val bestModelPath = new Path(path, "bestModel").toString
val bestModel =
DefaultParamsReader.loadParamsInstance[Model[_]](bestModelPath, sc)
val validationMetrics = (metadata.metadata \
"validationMetrics").extract[Seq[Double]].toArray
+ val shouldPersistSubModels = (metadata.metadata \
"persistSubModels").extract[Boolean]
--- End diff --
Same here; let's make this optional
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
