Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19588#discussion_r150718504
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala ---
@@ -219,6 +231,33 @@ class VectorIndexerSuite extends SparkFunSuite with
MLlibTestSparkContext
checkCategoryMaps(densePoints2, maxCategories = 2, categoricalFeatures
= Set(1, 3))
}
+ test("handle invalid") {
+ for ((points, pointsTestInvalid) <- Seq((densePoints1,
densePoints1TestInvalid),
+ (sparsePoints1, sparsePoints1TestInvalid))) {
+ intercept[SparkException] {
--- End diff --
Only wrap the part which should throw the exception in the intercept.
Otherwise, it might be masking some other error.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
