Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19692#discussion_r150751617
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -137,6 +137,8 @@ object TypeCoercion {
         case (DateType, TimestampType) => Some(StringType)
         case (StringType, NullType) => Some(StringType)
         case (NullType, StringType) => Some(StringType)
    +    case (n: DecimalType, s: StringType) => Some(DoubleType)
    --- End diff --
    
    add a comment to say that there is no proper decimal type we can pick, 
using double type is the best we can do.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to