Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19720#discussion_r150776245
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -357,7 +358,7 @@ case class AtLeastNNonNulls(n: Int, children:
Seq[Expression]) extends Predicate
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val nonnull = ctx.freshName("nonnull")
--- End diff --
I think it does, because having it as a global variable may put more
pressure on the constant pool (see SPARK-18016). Thus, whenever feasible, I do
think that we should keep it local.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
