Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150863818
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -262,37 +262,91 @@ case class CaseWhenCodegen(
// }
// }
// }
+
+ val isNull = ctx.freshName("caseWhenIsNull")
+ val value = ctx.freshName("caseWhenValue")
+
val cases = branches.map { case (condExpr, valueExpr) =>
--- End diff --
I see. Do you want to add such a code?
```
val cases = ...
val concatCases = cases.mkString("\nelse {\n")
if (concatCases.length > 1024) {
// current code
var isGlobalVariable = false
...
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
