Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/19640#discussion_r151253170
--- Diff: core/src/main/resources/org/apache/spark/ui/static/utils.js ---
@@ -46,3 +46,31 @@ function formatBytes(bytes, type) {
var i = Math.floor(Math.log(bytes) / Math.log(k));
return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' +
sizes[i];
}
+
+function padZeroes(num) {
+ return ("0" + num).slice(-2);
+}
+
+function formatTimeMillis(timeMillis) {
+ if (timeMillis <= 0) {
+ return "-";
+ } else {
+ var dt = new Date(timeMillis);
+ return dt.getFullYear() + "-" +
+ padZeroes(dt.getMonth() + 1) + "-" +
+ padZeroes(dt.getDate()) + " " +
+ padZeroes(dt.getHours()) + ":" +
+ padZeroes(dt.getMinutes()) + ":" +
+ padZeroes(dt.getSeconds());
+ }
+}
+
+function getTimeZone() {
+ try {
--- End diff --
Spark does not have a list of supported browsers, from my experience most
of us just test new UI changes on whatever browsers we have (In my case the
latest Safari, Chrome and Firefox ESR). Though I'd like to think we don't have
any IE users, we can't make that assumption while IE 11 is still supported by
MS.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
