Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r151333181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -75,9 +77,14 @@ class VectorizedHashMapGenerator(
}
}.mkString("\n").concat(";")
+ val columnVector = if (SparkEnv.get.memoryManager.tungstenMemoryMode
== MemoryMode.ON_HEAP) {
+ "OnHeapColumnVector"
+ } else {
+ "OffHeapColumnVector"
+ }
s"""
- | private
org.apache.spark.sql.execution.vectorized.OnHeapColumnVector[] batchVectors;
- | private
org.apache.spark.sql.execution.vectorized.OnHeapColumnVector[] bufferVectors;
+ | private
org.apache.spark.sql.execution.vectorized.WritableColumnVector[] batchVectors;
+ | private
org.apache.spark.sql.execution.vectorized.WritableColumnVector[] bufferVectors;
--- End diff --
We can use `$columnVector` instead of `WritableColumnVector`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
