Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19390#discussion_r151521265
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
 ---
    @@ -427,10 +444,10 @@ trait MesosSchedulerUtils extends Logging {
           // partition port offers
           val (resourcesWithoutPorts, portResources) = 
filterPortResources(offeredResources)
     
    -      val portsAndRoles = requestedPorts.
    -        map(x => (x, findPortAndGetAssignedRangeRole(x, portResources)))
    +      val portsAndResourceInfo = requestedPorts.
    +        map(x => (x, findPortAndGetAssignedResourceInfo(x, portResources)))
    --- End diff --
    
    Not caused by your change, but Spark's style is to use `.map { foo => ... 
}`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to