Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19741#discussion_r151538353
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -268,8 +268,13 @@ private[spark] abstract class YarnSchedulerBackend(
             logWarning(reason.toString)
             driverEndpoint.ask[Boolean](r).onFailure {
    --- End diff --
    
    Yeah, as you said, there's only logging going on. There's only two things 
that can happen:
    
    - the handler throws an exception instead of replying
    - the RPC layer hits an error
    
    The first can be logged at the handler (it not already logged by the RPC 
layer). The second is already logged by the RPC layer.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to