Github user mpetruska commented on the issue:

    https://github.com/apache/spark/pull/19671
  
    @jiangxb1987 : Well, I ran the `BlockManagerSuite` with `testOnly` and did 
not encounter any failures, passed 10 out of 10. Then, as a benchmark, I 
checked out the version without my changes and run the tests the same way, I 
got the same results 10 passed out of 10.
    
    I have these theories on the matter:
    - some other change fixed the issue
    - test failures only manifest when running multiple other tests in parallel
    - there's some setting/hardware on my machine that makes it very unlikely 
for the test to fail
    
    So, it turns out that unfortunately I cannot validate on my machine that 
removing the `Thread.sleep`s solves the flakiness issue.
    
    Can you please try running the tests on your machine with and without the 
proposed changes?
    (`4bacddb602e19fcd4e1ec75a7b10bed524e6989a` vs `SPARK-22297`)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to