Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19772#discussion_r151732579
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
    @@ -70,7 +70,8 @@ class SQLTransformer @Since("1.6.0") (@Since("1.6.0") 
override val uid: String)
         dataset.createOrReplaceTempView(tableName)
         val realStatement = $(statement).replace(tableIdentifier, tableName)
         val result = dataset.sparkSession.sql(realStatement)
    -    dataset.sparkSession.catalog.dropTempView(tableName)
    --- End diff --
    
    It seems like a bug: when you cache a dataframe, create a view from the 
dataframe, and drop the view, Spark should not uncache the original dataframe. 
We can discuss more later.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to