Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19769#discussion_r152053946
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -355,17 +362,33 @@ class ParquetFileFormat
fileSplit.getLocations,
null)
+ val sharedConf = broadcastedHadoopConf.value.value
+ // PARQUET_INT96_TIMESTAMP_CONVERSION says to apply timezone
conversions to int96 timestamps'
+ // *only* if the file was created by something other than
"parquet-mr", so check the actual
+ // writer here for this file. We have to do this per-file, as each
file in the table may
+ // have different writers.
+ def isCreatedByParquetMr(): Boolean = {
+ val footer = ParquetFileReader.readFooter(sharedConf,
fileSplit.getPath, SKIP_ROW_GROUPS)
--- End diff --
good point, we can avoid repeating this by moving it into
SpecificParquetRecordReaderBase for the vectorized reader, but we still need it
here for the non-vectorized path as we're reusing code from parquet-mr there.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
